Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WooCommerce-ize URL detection #110

Merged
merged 6 commits into from
Feb 3, 2025
Merged

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Feb 3, 2025

@tfirdaus
Copy link
Member

tfirdaus commented Feb 3, 2025

Thanks @szepeviktor. It's an awesome PR and works great.

Theres' just a minor bug in:

if (! URL::isLogin()) {
return;
}
The URL::isLogin() failed to identify the My Account as a page. I think because it's attached to init hook instead of wp. I can handle it after merging this PR.

@tfirdaus tfirdaus merged commit d405be9 into syntatis:main Feb 3, 2025
7 checks passed
@szepeviktor
Copy link
Contributor Author

Glad to contribute.

@szepeviktor szepeviktor deleted the patch-1 branch February 3, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants