Do not lock default setting value of syncthing daemon executable path in bundle #242
Conversation
There was a problem hiding this comment.
This looks even better then what I had in mind. The use case where a power-user sets a path outside the bundle is still valid with this fix. Not sure what I was thinking when locking the executable in the defaults store into the bundle. For some odd reason (new) people run .app from DMG on macOS, drag to applications and then unmount them. I'm not a fan of this usage, but the app should not break when people use it in this way.
|
Thanks @calmh for your effort digging through my code ! |
xor-gate
changed the title
|
@calmh could you enable edit by maintainers for this PR, the CI seems to be broken. Seems deprecated runner, need to upgrade to macos-14 at least (or do it yourself). Then I can test the DMG before putting it in develop. Thanks! |
|
It's a branch in the repo, you can just push to it :) |
|
Was unaware of it, thanks! |
…15 builder produces binary which doesn't run on macos 12
Since this is the number one complaint. Not tested, just looks reasonable.
Fixes #228