Added slow but thorough matrix benchmarks #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| from sympy import I, S, simplify | ||
| from sympy.simplify.simplify import simplify | ||
|
|
||
| _TEST_SIMPLIFY = False # test simplify after operation? |
There was a problem hiding this comment.
In the original benchmark since dotprodsimp was optional this was for comparing func(dotprodsimp=True) vs. simplify(func()). I left the code in just in case at some point someone wants to make the same comparison.
| def time_A(self): A**4 | ||
| def time_B(self): B**4 | ||
| def time_C(self): C**4 | ||
| def time_D(self): D**4 |
There was a problem hiding this comment.
Maybe could do
class _TimeMatrixBase:
def time_A(self): self.func(A)
def time_B(self): self.func(B)
def time_C(self): self.func(C)
def time_D(self): self.func(D)
class TimePow4(_TimeMatrixBase):
def func(self, M):
return M**4
There was a problem hiding this comment.
Probably, but at this point with my potentially limited time I am focusing on the actual matrix code...
|
Note that we specifically want to avoid slow benchmarks. I suggest that benchmarks should be under a second here: #8 |
|
Are the benchmarks in the |
|
I see. I guess those are not run, see #35. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were requested to test the new matrix intermediate simplification in sympy PR #18572.