Correctly list multiple authors in the wiki update #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically GitHub accepts POST to PATCH endpoints, but PATCH is more correct.
|
This also improves the code coverage of the pull_request_closed function #47. There are still several code paths that aren't tested, however. |
|
Live test: asmeurer/GitHub-Issues-Test#42 |
|
I am working on a script to update the existing notes. In the meanwhile, let's merge this so future updates are correct. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was showing multiple authors correctly in the bot comment, but only the first authors was actually being put on the wiki.
We will have to go through and fix the existing notes on the wiki manually. Perhaps a script can be written to do it.