-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SymPy version to 1.13.3 #22
Conversation
…jupyterlite-core<=0.4.5
Thanks. Is it possible to add something to the README that explains the process of updating the SymPy Live website like this? When I wanted to do this before I spent quite a while looking for the sympy version pin in this repo before coming to understand that it is in fact the jupyterlite packages that need to be updated and that first the sympy version pin needs to be updated in pyodide somewhere. Just something that explains how the version of sympy used in the website is even determined would have been very helpful. |
Also the instructions in the README don't seem to actually run the sympy live website. I spend quite a while fiddling around with that as well. How do you locally run the website? Can we add that to the README? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ivanistheone, this should work!
I agree with @oscarbenjamin about adding more developer documentation. I've been instructed to add some related aspects to sympy/sympy#27419; some of those directions will also apply to the questions raised here, but it probably makes sense for both sets of instruction to be separate.
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
See here for the new README in rendered form https://github.com/sympy/live/blob/jan_updates/README.md OMG, I can't belive I had shipped the old version with such bad/missing instructions... I guess I was really happy we got it running at the time ;) @oscarbenjamin Could you give the README a read and see if info makes sense before we merge this. |
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
README.md
Outdated
> [!NOTE] | ||
> Updating the version of SymPy running on [live.sympy.org/](https://live.sympy.org/) usually requires updating the version of `jupyterlab`, `jupyterlite-core`, and `jupyterlite-pyodide-kernel` listed in `requirements.txt`. Use the [upstream requirements file](https://github.com/jupyterlite/demo/blob/main/requirements.txt) as reference. See [here](https://pyodide.org/en/stable/usage/packages-in-pyodide.html) for the backage verison included in Pyodide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to mention here that the first step is updating the version in pyodide itself. Perhaps a link to this PR would show how this looks: pyodide/pyodide#5098.
Then only after pyodide actually makes a new release it becomes possible to update the jupyterlite version so that the website receives the new version of sympy. (I was confused when that PR got merged but the website did not immediately update. It is now several months later so maybe worth setting expectations clearly here.)
I assumed that was the case. I remember it all happening quite quickly when the website first got up and running.
Thanks, that is much better. I left two suggestions about other things that I had been unsure about when previously trying to study this repo:
|
This PR updates the packages
jupyterlab
,jupyterlite-core
to match the latest versions in jupyterlite/demo. I have also addedjupyterlite-pyodide-kernel>=0.4.7
in order to pull in the latest version of SymPy, as listed here.Closes: #20