WWSynmpa: do_distribute: Confirmation was not always performed #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version
6.2.37b and later.
Installation method
Any.
Expected behavior
When
distributeaction is initiated by requesting URIwwsympa_url/LIST/distribute/ID, confirmation steps should always be performed.Actual behavior
The confirmation steps are skipped, when message tagging is optional or no message tags are available on the list.
Steps to reproduce
Post a message to the list that requires holding messages for moderation. And follow the
distributelink for the held message.Note
For
rejectaction see #1704 also.