[Messenger] Fix some syntax issue #20687
Open
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
carsonbot
changed the title
carsonbot
changed the title
|
I think this is an oversight, because for Amazon SQS transport, the I've also noticed that the option |
|
Wouter, thanks for reviewing this. I've added some content based on the docs of these services. But, I have no experience in this, so please review it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the syntax issue, there's another pending issue: which option does it refer to? I can't see the
keepaliveoption in the list of options above it.So, is the option missing ... or should we delete this
versionaddeddirective?