Skip to content

Commit d678a57

Browse files
committed
feature #36681 [FrameworkBundle] use the router context by default for assets (nicolas-grekas)
This PR was merged into the 5.1-dev branch. Discussion ---------- [FrameworkBundle] use the router context by default for assets | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Follows #36651 and #21027 This means assets are going to be configured automatically most of the time. The only case where `asset.request_context.base_path` is useful is when the webserver still keeps a `/index.php/` in URLs. (I'm not sure if the doc should tell ppl to use the parameter, or if we should tell ppl to improve the config of their server...) Commits ------- 1ac5f68810 [FrameworkBundle] use the router context by default for assets
2 parents 119dcdf + 35dc48d commit d678a57

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

RequestContext.php

+5
Original file line numberDiff line numberDiff line change
@@ -319,4 +319,9 @@ public function setParameter(string $name, $parameter)
319319

320320
return $this;
321321
}
322+
323+
public function isSecure(): bool
324+
{
325+
return 'https' === $this->scheme;
326+
}
322327
}

0 commit comments

Comments
 (0)