Draft: Add property flag to specify an offset for the result path #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahumenberger
force-pushed
the
403-run-id
branch
from
f847f76 to
2517d2c
Compare
ahumenberger
reviewed
Feb 5, 2025
Munsio
commented
Feb 5, 2025
Munsio
commented
Feb 5, 2025
| @@ -148,6 +150,7 @@ func Evaluate(ctx *Context) { | |||
| } else { | |||
| runCount = rl + 1 | |||
| } | |||
| runID := ctx.RunIDOffset + runCount | |||
There was a problem hiding this comment.
If RunIDOffset is by default 1 shouldn't all evaluations where it is not set automatically start with runID: 2
There was a problem hiding this comment.
Not sure what you mean here.
ahumenberger
force-pushed
the
403-run-id
branch
from
2517d2c to
cfa997b
Compare
zimmski
reviewed
Feb 6, 2025
| @@ -73,6 +73,8 @@ type Evaluate struct { | |||
| Configuration string `long:"configuration" description:"Configuration file to set up an evaluation run."` | |||
| // ExecutionTimeout holds the timeout for an execution. | |||
| ExecutionTimeout uint `long:"execution-timeout" description:"Execution timeout for compilation and tests in minutes." default:"5"` | |||
| // RunIDOffset holds the offset increment for the run id used in creating the result folders. | |||
| RunIDOffset uint `long:"run-id-starts-at" description:"Sets the offset for the ID used in creating result folders." default:"0"` | |||
There was a problem hiding this comment.
That depends if the cli option is an "offset" or an "id-starts-at". I'm just working with what I got here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #403