fix: correct instance error messages & xdg var e2e-tests #3506
+23
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tri-adam
approved these changes
Feb 8, 2025
Ensure that action/instanceDbusXdg e2e-tests are correctly checking success / failure with the modified XDG env vars that are expected. Correct an incorrect debug message from copy/paste error. If the starter fails when starting an instance, output the starter StdErr to the terminal StdErr - previously we were writing started StdErr to terminal StdOut. Fixes sylabs#3494
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
Ensure that action/instanceDbusXdg e2e-tests are correctly checking success / failure with the modified XDG env vars that are expected.
Correct an incorrect debug message from copy/paste error.
If the starter fails when starting an instance, output the starter StdErr to the terminal StdErr - previously we were writing started StdErr to terminal StdOut.
This fixes or addresses the following GitHub issues:
Before submitting a PR, make sure you have done the following:
make checkand tested this PR locally with amake test, andmake testallif possible (see CONTRIBUTING.md).