Update todo-app.md #785
Update todo-app.md #785
Conversation
Just followed introduction tutorial and faced an outdated part. Web_sys window api is a feature and it is required for the local_storage access. And it returns an result so unwrap/expect is required. https://docs.rs/web-sys/0.3.77/web_sys/struct.Window.html#method.local_storage Also looks like KeyboardEvents are now part of sycamore, not web_sys
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #785 +/- ##
=======================================
Coverage 71.42% 71.42%
=======================================
Files 45 45
Lines 6659 6659
=======================================
Hits 4756 4756
Misses 1903 1903 ☔ View full report in Codecov by Sentry. |
|
Sycamore has it’s own reexport of window which handles the unwrap already: https://docs.rs/sycamore/latest/sycamore/prelude/fn.window.html Maybe we should make it more explicit that we import the prelude first? |
| @@ -355,8 +355,8 @@ Here is the complete code listing for the todo app. | |||
|
|
|||
| ```rust | |||
| use serde::{Deserialize, Serialize}; | |||
| use sycamore::prelude::*; | |||
| use web_sys::KeyboardEvent; | |||
| use sycamore::{prelude::*, web::events::KeyboardEvent}; | |||
There was a problem hiding this comment.
Very small thing but could you split this up into two use statements? This is how it is formatted in other places as well just for consistency.
There was a problem hiding this comment.
I should have just copied and build the tutorial code before submitting this issue. Rust-analyzer was screaming at me that window function doesn't exist, that is why I searched for web_sys local storage requirements. I will close this pull request. Thanks for your time :)
Just followed introduction tutorial and faced an outdated part.
Web_sys window api is a feature and it is required for the local_storage access. And it returns an result so unwrap/expect is required.
Docs
Also looks like KeyboardEvents are now part of sycamore, not web_sys.