Support query parameters in routes

[davidon-top]

closes: #130
also fixes bug that when going from a url with hash to a url with no hash (and with the same path) it causes a reload of the whole site (it was probably there before i started coding new features but i don't know for sure)

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 111 lines in your changes missing coverage. Please review.

Project coverage is 71.32%. Comparing base (eb134c8) to head (35a7cb9).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/sycamore-router/src/router.rs	0.00%	111 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #752      +/-   ##
==========================================
- Coverage   72.35%   71.32%   -1.03%     
==========================================
  Files          45       45              
  Lines        6557     6648      +91     
==========================================
- Hits         4744     4742       -2     
- Misses       1813     1906      +93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[davidon-top]

I couldn't find web tests for the router and i'm not sure if u want me to add them to sycamore web tests or create new web tests in sycamore-router (or not write tests at all), (i manually tested it at least)

[lukechu10]

I couldn't find web tests for the router and i'm not sure if u want me to add them to sycamore web tests or create new web tests in sycamore-router (or not write tests at all), (i manually tested it at least)

I'm not actually sure how to create web tests in this case since navigating will take you away from the generated wasm test page and thus stop the test. It would be nice if we could find a way to test this but for now this is fine I think.

[davidon-top]

personally i would test this with an e2e test using selenium (at my previous job (softwareag, working student) that is all i did)

[lukechu10]

personally i would test this with an e2e test using selenium (at my previous job (softwareag, working student) that is all i did)

Yeah something like that would work but that probably belongs in another PR. I was hoping to get e2e tests for all the examples as well so we could just e2e test the router example for this case.

[lukechu10]

I've added an example of query parameters to the router example. Also left a few comments.

[davidon-top]

i just realized i accidentally deleted the functions from my previous pr (prob during merge or stash pop)

[lukechu10]

Ok I'm running into something a little weird where the query parameter seems to require two page navigations for it to be reset.

Recording.2024-11-04.mp4

I'm trying to figure out why now...

[lukechu10]

Ah got it. It's because we're calling pathname.set before calling the history API, causing everything to be delayed by one.

[lukechu10]

I also updated the order in the naviagte_* fuctions which essentially have the same logic as the click handler. Eventually, it would be a good idea to refactor this a bit to remove the duplicate logic.