Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix embedded books false positives #9

Open
swquinn opened this issue Jul 2, 2019 · 0 comments
Open

Fix embedded books false positives #9

swquinn opened this issue Jul 2, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@swquinn
Copy link
Owner

swquinn commented Jul 2, 2019

When loading books, we are logging false positives on the discovery of "embedded" books.

What is happening is that we're finding the first path with a valid book configuration and then continuing to look through sub directories, and when we find a subdirectory we're saying that we found an embedded book even though there's no valid configuration there.

We should either just ignore subdirectories or, as we iterate over them only alert that we found an embedded book when we encounter a valid configuration file in the subdirectory of a book.

@swquinn swquinn added the bug Something isn't working label Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant