Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 03-create.md - Case sensitivity #1393

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Richard-Regan
Copy link

Added a Call out section on case sensitivity.

Added a Call out section on case sensitivity.
@github-actions
Copy link

github-actions bot commented May 16, 2023

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

It should be safe to Approve and Run the workflows that need maintainer approval.

github-actions bot pushed a commit that referenced this pull request May 16, 2023
@bkmgit
Copy link
Contributor

bkmgit commented May 16, 2023

Thanks. It is a little long and there may be differences between different versions of operating systems. Mac OS has recently switched to zsh as default, though the lesson mostly works ok. Is it possible to reduce it to one or two sentences at most without its own section. The lesson is already quite long and many instructors have trouble finishing.

@Richard-Regan
Copy link
Author

Richard-Regan commented May 16, 2023 via email

@bkmgit
Copy link
Contributor

bkmgit commented May 16, 2023

That would be really great. Thanks for your patience and perseverance.

Copy link
Contributor

@deppen8 deppen8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this addition is a bit too much for this early part of the lesson. I made some suggestions that might help it be a little more succinct.


::::::::::::::::::::::::::::::::::::::::: callout

## Case Sensitivity
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Case Sensitivity
## Case sensitivity

Section headers don't use full title case in our style guide.


## Case Sensitivity

This is normally driven by the underlying OS. In most implementations of BASH it is case sensitive, with the exception of MacOS which is case insensitive. Some OSs have predefined directories that use a capital letter at the start, such as Download, and Desktop. This is used to make these directors stand out.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This is normally driven by the underlying OS. In most implementations of BASH it is case sensitive, with the exception of MacOS which is case insensitive. Some OSs have predefined directories that use a capital letter at the start, such as Download, and Desktop. This is used to make these directors stand out.
Whether or not your Bash shell is case-sensitive is normally determined by the underlying operating system (Windows, MacOS, Linux, etc.). In most implementations of Bash, it _is_ case sensitive. On MacOS, however, it is not case sensitive.


This is normally driven by the underlying OS. In most implementations of BASH it is case sensitive, with the exception of MacOS which is case insensitive. Some OSs have predefined directories that use a capital letter at the start, such as Download, and Desktop. This is used to make these directors stand out.

It is standard practice to use lowercase for your files and directories, but this is only a guideline.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It is standard practice to use lowercase for your files and directories, but this is only a guideline.
It can be a good practice to use all lowercase for files and directories, but this is not a rule; you are likely to see uppercase used in practice.

Comment on lines 161 to 165
If you choose to use capital letters at the start of your file names, you should bear in mind the fact that sorting order in Unix is (sometimes) case sensitive, and some commands such as grep you may need additional options to achieve the desired result.

Also this effect is negligible if the letter isn't the first letter in the name, so it's not an issue if you use naming standards such as camelCase.


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you choose to use capital letters at the start of your file names, you should bear in mind the fact that sorting order in Unix is (sometimes) case sensitive, and some commands such as grep you may need additional options to achieve the desired result.
Also this effect is negligible if the letter isn't the first letter in the name, so it's not an issue if you use naming standards such as camelCase.

Some of this is rolled into my previous suggestion and the camelCase bit is probably too much for this early in the lesson.

Added short section on case sensitivity to the Good names section.
@Richard-Regan
Copy link
Author

Hi I have amended this addition, by removing the section and adding the reduced text to the section on "Good names"

@Richard-Regan
Copy link
Author

Richard-Regan commented May 18, 2023 via email

@bkmgit
Copy link
Contributor

bkmgit commented May 18, 2023 via email

@gcapes
Copy link
Contributor

gcapes commented May 18, 2023

Before merging this, can we please confirm the case-sensitivity on Windows? I thought that Windows was the outlier here not being case sensitive, while linux and macos were. But after a google search it seems that indeed macos is case insensitive too, so it's just linux which is case sensitive(?)

I know it's not really the OS, but rather the filesystem used, but I'm talking default behaviour here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants