Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: source map error with source-map-explorer #9659

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

SyMind
Copy link
Contributor

@SyMind SyMind commented Oct 18, 2024

Description:

Relative web-infra-dev/rspack#7914

BREAKING CHANGE:

Related issue (if exists):

Copy link

changeset-bot bot commented Oct 18, 2024

⚠️ No Changeset found

Latest commit: ead08fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

socket-security bot commented Oct 18, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/ajv@6.12.6 eval 0 929 kB esp
npm/deep-is@0.1.4 None 0 8.11 kB thlorenz
npm/eslint-visitor-keys@3.4.3 None 0 32.3 kB eslintbot
npm/esquery@1.6.0 None 0 1.04 MB michaelficarra
npm/esrecurse@4.3.0 None 0 13.5 kB michaelficarra
npm/estraverse@5.3.0 None 0 37.1 kB michaelficarra
npm/fast-deep-equal@3.1.3 None 0 13 kB esp
npm/fast-levenshtein@2.0.6 None 0 9.44 kB hiddentao
npm/ignore@5.3.2 None 0 53.6 kB kael
npm/json-schema-traverse@0.4.1 None 0 19.6 kB esp
npm/json-stable-stringify-without-jsonify@1.0.1 None 0 14.2 kB samn
npm/levn@0.4.1 None 0 24.9 kB gkz
npm/lodash.merge@4.6.2 None 0 54.1 kB jdalton
npm/optionator@0.9.4 None 0 50.2 kB gkz
npm/prelude-ls@1.2.1 None 0 36.7 kB gkz
npm/punycode@2.3.1 None 0 33.5 kB google-wombot
npm/text-table@0.2.0 None 0 11 kB substack
npm/type-check@0.4.0 None 0 21.2 kB gkz
npm/uri-js@4.4.1 None 0 470 kB garycourt
npm/word-wrap@1.2.5 None 0 11.8 kB jonschlinkert

🚮 Removed packages: npm/array-buffer-byte-length@1.0.0, npm/available-typed-arrays@1.0.5, npm/binary-extensions@2.2.0, npm/call-bind@1.0.7, npm/decamelize@4.0.0, npm/define-properties@1.2.0, npm/es-abstract@1.21.2, npm/es-define-property@1.0.0, npm/es-errors@1.3.0, npm/es-set-tostringtag@2.0.1, npm/es-to-primitive@1.2.1, npm/flat@5.0.2, npm/function.prototype.name@1.1.5, npm/get-symbol-description@1.0.0, npm/glob-parent@5.1.2, npm/globalthis@1.0.3, npm/gopd@1.0.1, npm/has-proto@1.0.1, npm/has-symbols@1.0.3, npm/hosted-git-info@2.8.9, npm/internal-slot@1.0.5, npm/is-binary-path@2.1.0, npm/is-extglob@2.1.1, npm/is-negative-zero@2.0.2, npm/is-plain-obj@2.1.0, npm/is-regex@1.1.4, npm/is-shared-array-buffer@1.0.2, npm/is-string@1.0.7, npm/is-typed-array@1.1.10, npm/is-unicode-supported@0.1.0, npm/is-weakref@1.0.2, npm/load-json-file@4.0.0, npm/memorystream@0.3.1, npm/nanoid@4.0.2, npm/nice-try@1.0.5, npm/normalize-package-data@2.5.0, npm/npm-run-all@4.1.5, npm/object-keys@1.1.1, npm/object.assign@4.1.4, npm/pify@3.0.0, npm/randombytes@2.1.0, npm/read-pkg@3.0.0, npm/readdirp@3.6.0, npm/regexp.prototype.flags@1.5.0, npm/safe-regex-test@1.0.0, npm/set-function-length@1.2.1, npm/shell-quote@1.8.1, npm/string.prototype.padend@3.1.4, npm/string.prototype.trim@1.2.7, npm/validate-npm-package-license@3.0.4, npm/workerpool@6.2.0, npm/yargs-unparser@2.0.0

View full report↗︎

Copy link

codspeed-hq bot commented Oct 18, 2024

CodSpeed Performance Report

Merging #9659 will improve performances by 3.1%

Comparing SyMind:source-validator (ead08fa) with main (f735108)

Summary

⚡ 1 improvements
✅ 193 untouched benchmarks

Benchmarks breakdown

Benchmark main SyMind:source-validator Change
es/oxc/benches/assets/UserSettings.tsx/sourceMap=true/reactDev=false 1.6 ms 1.5 ms +3.1%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant