Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined params if using by stauren/vite-plugin-deadfile #9529

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Leubeling
Copy link

Description:

I use this library indirectly through stauren/vite-plugin-deadfile. I noticed an exception which occurs with every build due to an undefined array.

BREAKING CHANGE:

Related issue (if exists):

error during build:
[vite-plugin-pwa:build] Cannot read properties of undefined (reading 'map')
file: /projectfolder/src/main.ts
    at ImportVisitor.visitTsFnParameters (/projectfolder/node_modules/@swc/core/Visitor.js:589:23)
    at ImportVisitor.visitTsPropertySignature (/projectfolder/node_modules/@swc/core/Visitor.js:511:25)
    at ImportVisitor.visitTsTypeElement (/projectfolder/node_modules/@swc/core/Visitor.js:489:29)
    at Array.map (<anonymous>)
    at ImportVisitor.visitTsTypeElements (/projectfolder/node_modules/@swc/core/Visitor.js:480:22)
    at ImportVisitor.visitTsInterfaceBody (/projectfolder/node_modules/@swc/core/Visitor.js:476:23)
    at ImportVisitor.visitTsInterfaceDeclaration (/projectfolder/node_modules/@swc/core/Visitor.js:472:23)
    at ImportVisitor.visitDeclaration (/projectfolder/node_modules/@swc/core/Visitor.js:404:29)
    at ImportVisitor.visitStatement (/projectfolder/node_modules/@swc/core/Visitor.js:235:29)
    at ImportVisitor.visitModuleItem (/projectfolder/node_modules/@swc/core/Visitor.js:40:29)

@Leubeling Leubeling requested a review from a team as a code owner September 3, 2024 10:47
Copy link

changeset-bot bot commented Sep 3, 2024

⚠️ No Changeset found

Latest commit: 06bf4cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Sep 3, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codspeed-hq bot commented Sep 3, 2024

CodSpeed Performance Report

Merging #9529 will degrade performances by 7.84%

Comparing Leubeling:fix (06bf4cd) with main (c7fdd6b)

Summary

❌ 1 regressions
✅ 177 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main Leubeling:fix Change
es/full/bugs-1 531.7 µs 576.9 µs -7.84%

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't recommend using JS plugins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants