Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: Remove __all__ export from application.py #1651

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

svix-mman
Copy link
Contributor

__all__ allows a from svix.api.application import *, but this was never a supported feature. And the __all__ is not in any of the other modules.

`__all__` allows a `from svix.api.application import *`, but this was never a supported feature. And the `__all__` is not in any of the other modules.
@svix-mman svix-mman requested a review from a team as a code owner January 20, 2025 17:23
@svix-jplatte
Copy link
Member

Not having __all__ does not mean that * imports don't work, it means that the * import imports every symbol from the module that's not _-prefixed. Still, makes sense to remove __all__.

@svix-jplatte svix-jplatte merged commit 88c0496 into main Jan 20, 2025
8 checks passed
@svix-jplatte svix-jplatte deleted the mendy/remove-explicit-export-from-application-py branch January 20, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants