[lib/c#] Return iterator information in list endpoints #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svix-lucho
force-pushed
the
lucho/list-in-c-sharp
branch
from
cc1e941 to
0d582ad
Compare
svix-onelson
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our list endpoints, e.g., Endpoint.List, Endpoint.ListAsync, do not return pagination data, which makes the library unusable if results are paginated. We need to return the full response, and not just the data portion of it.
Solution
Return the full response (
data,iteratoranddone) from the listing methods.This is a breaking change. Users upgrading to the latest version of the C# lib will need to update their usage of these endpoints.
var res = Application.List(...)becomesvar res = Application.List(...).Data.Fixes #1200