Make Cubit installation optional #195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connoramoreno
commented
Feb 10, 2025
| mesh_volume_skeleton, | ||
| get_last_id, | ||
| ) | ||
| from . import cubit_utils |
There was a problem hiding this comment.
I'd like to note (for reviewers) that cubit_utils is imported separately here for its initialized variable. If initialized is imported into the namespace of magnet_coils, changes to the variable do not persist when modified by calls to the imported functions
|
I would also like to note that all tests indeed pass (other than those skipped) when Cubit is removed from |
Edgar-21
reviewed
Feb 10, 2025
| def get_last_id(entity): | ||
| """Returns the ID of the most recently created entity of a given type. | ||
|
|
||
| Arguments: |
There was a problem hiding this comment.
might be nice to list valid strings here for anyone who is not familiar with the entity types in cubit.
|
Do we want to update the example parastell_cad_to_dagmc_example.py to not use cubit at all? Right now it calls cubit to make a volumetric mesh of the magnets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch isolates the use of Cubit within ParaStell such that it becomes an optional dependency. Cubit import occurs in a single location, the
init_cubitfunction of thecubit_utils.pyscript (formerly namedcubit_io.py), which is called only in functions using Cubit. As the radial distance utility is completely dependent on Cubit, no major modifications were made to that script. In addition, tests are modified to test Cubit functionality only if installed, includingtest_parastell.py.