removed divider code and updated readme

suusan2go · Sep 9, 2020 · 514d46a · 514d46a
1 parent 81c30eb
commit 514d46a
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 49 deletions.
diff --git a/README.md b/README.md
@@ -116,7 +116,6 @@ Name | Type | Default | Description
 value | Object | [] | items for treeview. `item-key`, `item-text`, `item-children` are not customizable currently.  `value` can be like `{ id: 1, name: "test", children: []}` .
 group | string | null | group name for vuedraggable. If this props not provided, drag and drop are enabled only in children.
 expand-icon | string | 'mdi-menu-down' |mdi string for the expand icon.
-show-divider | boolean | false |show a divider under each node.
 
 ### Events
 Name | Value  | Description

diff --git a/src/DraggableTreeview.vue b/src/DraggableTreeview.vue
@@ -13,7 +13,6 @@
       :group="group"
       :value="item"
       :expand-icon="expandIcon"
-      :show-divider="showDivider"
       @input="updateItem"
     >
       <template v-slot:prepend="{ item, open }">
@@ -53,10 +52,6 @@ export default Vue.extend({
     expandIcon: {
       type: String,
       default: "mdi-menu-down"
-    },
-    showDivider: {
-      type: Boolean,
-      default: (): boolean => false
     }
   },
   data() {

diff --git a/src/DraggableTreeviewNode.vue b/src/DraggableTreeviewNode.vue
@@ -33,16 +33,6 @@
       </div>
       <slot name="append" v-bind="{ item: value }" />
     </div>
-    <hr
-      v-if="showDivider"
-      role="separator"
-      aria-orientation="horizontal"
-      class="v-divider"
-      :class="{
-        'theme--dark': isDark,
-        'theme--light': !isDark
-      }"
-    />
     <div
       v-if="open"
       class="v-treeview-node__children v-treeview-node__children__draggable"
@@ -60,7 +50,6 @@
           :value="child"
           :level="level + 1"
           :expand-icon="expandIcon"
-          :show-divider="showDivider"
           @input="updateChildValue"
         >
           <template v-slot:prepend="{ item, open }">
@@ -114,10 +103,6 @@ export default Vue.extend({
     expandIcon: {
       type: String,
       default: "mdi-menu-down"
-    },
-    showDivider: {
-      type: Boolean,
-      default: (): boolean => false
     }
   },
   data() {

diff --git a/test/DraggableTreeview.spec.js b/test/DraggableTreeview.spec.js
@@ -38,7 +38,7 @@ describe("DraggableTreeview", () => {
     });
   });
 
-  test("renders correctly with divider and changed expand Icon", () => {
+  test("renders correctly with changed expand Icon", () => {
     const wrapper = mount(DraggableTreeview, {
       vuetify: new Vuetify({
         mocks: {
@@ -63,7 +63,6 @@ describe("DraggableTreeview", () => {
             ]
           }
         ],
-        showDivider: true,
         expandIcon: "mdi-chevron-down"
       }
     });

diff --git a/test/__snapshots__/DraggableTreeview.spec.js.snap b/test/__snapshots__/DraggableTreeview.spec.js.snap
@@ -27,8 +27,6 @@ exports[`DraggableTreeview renders correctly 1`] = `
     </div>
      
     <!---->
-     
-    <!---->
   </div>
 </div>
 `;
@@ -59,8 +57,6 @@ exports[`DraggableTreeview renders correctly 2`] = `
        
     </div>
      
-    <!---->
-     
     <div
       class="v-treeview-node__children v-treeview-node__children__draggable"
     >
@@ -91,16 +87,14 @@ exports[`DraggableTreeview renders correctly 2`] = `
           </div>
            
           <!---->
-           
-          <!---->
         </div>
       </div>
     </div>
   </div>
 </div>
 `;
 
-exports[`DraggableTreeview renders correctly with divider and changed expand Icon 1`] = `
+exports[`DraggableTreeview renders correctly with changed expand Icon 1`] = `
 <div
   class="v-treeview v-treeview-draggable theme--light"
 >
@@ -126,18 +120,12 @@ exports[`DraggableTreeview renders correctly with divider and changed expand Ico
        
     </div>
      
-    <hr
-      aria-orientation="horizontal"
-      class="v-divider theme--light"
-      role="separator"
-    />
-     
     <!---->
   </div>
 </div>
 `;
 
-exports[`DraggableTreeview renders correctly with divider and changed expand Icon 2`] = `
+exports[`DraggableTreeview renders correctly with changed expand Icon 2`] = `
 <div
   class="v-treeview v-treeview-draggable theme--light"
 >
@@ -163,12 +151,6 @@ exports[`DraggableTreeview renders correctly with divider and changed expand Ico
        
     </div>
      
-    <hr
-      aria-orientation="horizontal"
-      class="v-divider theme--light"
-      role="separator"
-    />
-     
     <div
       class="v-treeview-node__children v-treeview-node__children__draggable"
     >
@@ -198,12 +180,6 @@ exports[`DraggableTreeview renders correctly with divider and changed expand Ico
              
           </div>
            
-          <hr
-            aria-orientation="horizontal"
-            class="v-divider theme--light"
-            role="separator"
-          />
-           
           <!---->
         </div>
       </div>