-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please check and let's discuss a merge #12
Open
BennyTheDev
wants to merge
49
commits into
supertestnet:main
Choose a base branch
from
BennyTheDev:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ adjusted howto in brc20 transfer
+ replaced BTON with TAPSCRIPT as the project moved there + added a recovery feature: depending at what state a session fails, the user can either return funds sent to the funding address or continue with failed inscriptions (a "cashout" of failed inscriptions is currently not possible) + set back the default fee rate to medium as it has been requested in "rush hour" scenarios by users
+ adjusted calculations for text based inscription to save some fees
+ adjusted the height of text inscriptions + fixed the summary so things add up properly
+ adjusted the height of text inscriptions + fixed the summary so things add up properly
+ updated text inscriptions to be multi-row or single rows
+ optimized fee rate for dev tipping
…nd everything is being generated
…xistence.php is not present or not executable OR the unisat api unavailable
…ine js from html + removed signet.html as it is not required any longer due to the use of app-config + added a basic nav menu + added ord/eth bridge support (looksordinal project specific) + added a looksordinal project specific univ page
+ added temporary loot for taproot support
There are too many code changes, I don't want to review all of this |
+ moved php files to api folder + added the sats resolver plugin
+ moved php files to api folder + added the sats resolver plugin
…value backups prior to broadcasting + now allowing brc20 tickers from 2 to 4 characters to support iconized tickers.
…value backups prior to broadcasting + now allowing brc20 tickers from 2 to 4 characters to support iconized tickers.
…value backups prior to broadcasting + now allowing brc20 tickers from 2 to 4 characters to support iconized tickers.
+ added a txdata test to check if the generated keys would be leading to a valid tx + now allowing up to 500 sats/vb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed a lot. What is the best strategy to merge this?