Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ac3 (5.1) audio - 6 channels #65

Merged
merged 23 commits into from
Oct 17, 2024
Merged

Support ac3 (5.1) audio - 6 channels #65

merged 23 commits into from
Oct 17, 2024

Conversation

matvp91
Copy link
Collaborator

@matvp91 matvp91 commented Oct 14, 2024

Sneak peak:

image

  • I think there's a bug in HLS.js with setAudioOption, particularly at https://github.com/video-dev/hls.js/blob/master/src/utils/rendition-helper.ts#L486, where if index is 0, it'll be skipped entirely.
  • When selecting a new group (eg; from aac to ac3), level selection is reset. We should preserve that, or look at HLS.js if they have some sort of logic to do it for us. Nonetheless, due to this behavior, facade thinks it's not in ABR mode when HLS.js is auto selecting quality.
  • We should ship with a map of common lang to label.

@matvp91 matvp91 merged commit 6697f0c into main Oct 17, 2024
2 of 4 checks passed
@matvp91 matvp91 deleted the feature/ac3-channels branch October 19, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant