You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests should have been removed as part of dropping support for PHP 7.4, but I had completely forgotten that some of the tests were targeting PHP 7 specifically. Anyway, we can remove them now.
These tests should have been removed as part of dropping support for PHP 7.4, but I had completely forgotten that some of the tests were targeting PHP 7 specifically. Anyway, we can remove them now.
oh I need to do a more thorough reviewing as well. Are you planning to add tests for the newer versions then?
These tests should have been removed as part of dropping support for PHP 7.4, but I had completely forgotten that some of the tests were targeting PHP 7 specifically. Anyway, we can remove them now.
oh I need to do a more thorough reviewing as well. Are you planning to add tests for the newer versions then?
@dawitnida, half of the files in the PR are _php7 files that I remove. The other half are _php8 files that I rename. So we already have tests for the newer versions. 🙂
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests should have been removed as part of dropping support for PHP 7.4, but I had completely forgotten that some of the tests were targeting PHP 7 specifically. Anyway, we can remove them now.