Add support for PHP 8.4 (nightly) and run tests also on PHP 8.4

supermetrics-public · Dec 19, 2023 · 40a17ff · 40a17ff
1 parent 66fe60a
commit 40a17ff
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -14,7 +14,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php: [ "8.0", "8.1", "8.2", "8.3" ]
+        php: [ "8.0", "8.1", "8.2", "8.3" "8.4" ]
         use-opcache: [ "true", "false" ]
 
     steps:

diff --git a/src/jsonpath/interpreter.c b/src/jsonpath/interpreter.c
@@ -293,7 +293,11 @@ static bool compare_rgxp(zval* lh, zval* rh) {
 
   zend_string* zs_lh = zend_string_copy(Z_STR_P(lh));
 
+#if PHP_VERSION_ID >= 80400
+  php_pcre_match_impl(pce, zs_lh, &retval, &subpats, 0, 0, 0);
+#else
   php_pcre_match_impl(pce, zs_lh, &retval, &subpats, 0, 0, 0, 0);
+#endif
 
   zend_string_release_ex(zs_lh, 0);
   zval_ptr_dtor(&subpats);