Do not throw when pushing to errored or closed channel #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roughike
commented
Jul 16, 2024
| _logger.finest( | ||
| () => 'Buffering push ${pushEvent.ref} for later send ($_state)'); | ||
| pushEvent.startTimeout(); |
There was a problem hiding this comment.
wish there was an easy way to test this
brian-superlist
approved these changes
Jul 16, 2024
roughike
deleted the
do-not-throw-when-pushing-to-errored-or-closed-channel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throwing in this scenario prevents the channel from recovering as throwing interrupts code execution and adding events to the
pushBufferto be retried on successful reconnect.The reference JS implementation does not throw either and this PR brings the behavior closer to the reference implementation: https://github.com/phoenixframework/phoenix/blob/25e891f172045aa0391d30bfd794111235041159/assets/js/phoenix/channel.js#L183-L184