Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optional minting to JettonInit #30

Merged
merged 10 commits into from
Jan 15, 2025

Conversation

iamIcarus
Copy link
Collaborator

PR Description

Title:

feat: add optional minting to JettonInit


Key Points

  • Optional Minting:

    • Added support for minting tokens during JettonInit if mint_amount > 0.
    • Skips minting if mint_amount is 0 or null.
  • Dynamic Minting Logic:

    • Updated mint function to accept an optional value parameter.
    • Uses SendRemainingValue or specified value with mode 0 dynamically.
  • Test Cases Added:

    • Test 1: Validates successful initialization with minting (mint > 0).
    • Test 2: Ensures proper error handling for non-active wallets (mint = 0).

@iamIcarus iamIcarus force-pushed the feature/mint-tokens-on-init branch from 85424cd to 2119ea0 Compare January 14, 2025 18:44
@iamIcarus iamIcarus linked an issue Jan 14, 2025 that may be closed by this pull request
Copy link
Member

@ya7on ya7on left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for such a big Pull Request!

}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should set up prettier for project. Because my vscode plugin for tact deletes these line breaks automatically. Not related to this issue. Just thoughts. I will open issue for it

Copy link
Member

@ya7on ya7on left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ya7on ya7on added this pull request to the merge queue Jan 15, 2025
Merged via the queue into supadupadao:master with commit 11a1fb0 Jan 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Tokens to mint init parameter
2 participants