Implement Tokens to mint init parameter

[ya7on]

Some other jetton implementations have initial "Tokens to mint" parameter. It allows mint tokens on jetton deploy phase.
I think we should implement that parameter and add it to JettonInit and if it's present, specified amount of tokens will be minted and transfered to owner account

[iamIcarus]

i'm working on this at feature/mint-tokens-on-init , possible to have a quick look (if you have some free time) on why it fails to mint at JettonInit?

i have a test you can run npm run test tests/JettonInit and at the first test case it should try to init and mint 10 jettons. It looks like a gas issue , cant quite pinpoint why.

[ya7on]

Hello @iamIcarus I looked at your code. My guess the issue is in multiple sends with SendRemainingValue mode. At first contract send toncoins at self.notify() and after that it trying to send more toncoins in self.mint()
I tried to comment notify line and tests passed.

Recently read Tact docs and find out about storageReserve parameter in BaseTrait. Maybe it could help with that. Tomorrow i can take a closer look.

[iamIcarus]

thank you for taking a look and for the pointers , much appreciated! I’ll look into storageReserve

[iamIcarus]

@ya7on what's your thoughts on this commit and the way gas is calculated?

[ya7on]

Looks complicated. But i can't imagine how to simplify it.
Do we really need JettonInitOk notification? 🤔 What role does it play? If it's about sending toncoins change, JettonInternalTransfer will handle it and send Excess message. If it's about onchain trigger for emitting finish jetton initialization, JettonInternalTransfer also will handle it and send JettonNotification message.
What do you think about send JettoninitOk only if mint_amount is not provided?

[iamIcarus]

i was thinking about it as well, my thoughts are that JettonInitOk will give us a simple solution to only have to monitor one notification to confirm that init was success for all cases within init (and in the case that init gets more logic added in the future).

It does look overcomplicated, wanted to check with you if you have any suggestions or improvements 😃

The general idea of this implementation is:

1. Keep JettonInitOk as a single source for init confirmation
2. Preserve the mint message receive logic with SendRemainingValue
3. JettonInit will need to calculate gas for the mint, so if something goes wrong, we can revert to simple init and mint in a new message

[ya7on]

Ok, I agree with the idea of JettonInitOk as single notification. It looks useful.

Also i think we should send this message after jetton transfering and put remaining toncoins to it, not to mint message. Because if user hasn't set mint_amount, change won't be returned.

[iamIcarus]

Also i think we should send this message after jetton transfering and put remaining toncoins to it, not to mint message. Because if user hasn't set mint_amount, change won't be returned.

good catch , i'll rework that part