fix: add MFA for WebAuthn bindings #960
Conversation
| credential_request_options: { publicKey: PublicKeyCredentialRequestOptionsJSON } | ||
| } | ||
| error: null | ||
| } | ||
| | { data: null; error: AuthError } | ||
|
|
||
| export type AuthMFAListFactorsResponse = |
There was a problem hiding this comment.
Decide whether to include aaguid to image / authenticator type mapping for user: https://github.com/passkeydeveloper/passkey-authenticator-aaguids
or to include it in documentation
|
|
||
| /** Timestamp in UNIX seconds when this challenge will no longer be usable. */ | ||
| expires_at: number | ||
| credential_creation_options: { publicKey: PublicKeyCredentialCreationOptionsJSON } |
There was a problem hiding this comment.
Try to see if it's possible to merge this into a single type again
| * | ||
| * Helper method to compliment `bufferToBase64URLString` | ||
| */ | ||
| export function base64URLStringToBuffer(base64URLString: string): ArrayBuffer { |
There was a problem hiding this comment.
Can switch to base64URL-js as well. This is taken from simplewebauthn, I think they should be similar functionally
| cause: Error | ||
| name?: string | ||
| }) { | ||
| // @ts-ignore: help Rollup understand that `cause` is okay to set |
There was a problem hiding this comment.
The build fails because of this ts-ignore comment in this helper function, which is ported over from simple-webauthn. Removing this and the related function for identifying the type of navigator error will allow the build to compile.
Still figuring out how to resolve this so we can keep the function.
| * The two types of credentials as defined by bit 3 ("Backup Eligibility") in authenticator data: | ||
| * - `"singleDevice"` credentials will never be backed up | ||
| * - `"multiDevice"` credentials can be backed up | ||
| */ |
There was a problem hiding this comment.
Types are ported from Simple-WebAuthn will add a comment to acknowledge.
What kind of change does this PR introduce?
We introduce bindings for MFA (WebAuthn) which consists of the following:
enroll()a. Single Step -
enroll({factorType: 'webauthn'})b. Multi-Step -
enroll(factorType: 'webauthn, webAuthn{...})challenge()-verify()a. Single Step -
verify({factorType: 'webauthn'})b. Multi-Step -
verify({factorType: 'webauthn', webAuthn{..}})We also expose a few helper methods:
identifyAuthenticationErrorbrowserSupportsWebAuthn