Remove unnecessary locale defaults; they don't seem necessary, and br… #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eak named URL routes. Fixes #1349
cbeer
force-pushed
the
1349-locale-routes
branch
5 times, most recently
from
de8f5df
to
160d788
Compare
…se used in the app
cbeer
force-pushed
the
1349-locale-routes
branch
from
160d788
to
d2dc69f
Compare
|
This looks good to me from a code perspective. I haven't tested the functionality yet though. |
|
We should determine if this is still needed. This PR in exhibits fixed the issue also being addressed here: projectblacklight/spotlight#2360 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eak named URL routes. Fixes #1349