-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal to external css #4514
base: master
Are you sure you want to change the base?
internal to external css #4514
Conversation
✅ All Jest tests passed! This PR is ready to merge. |
1 similar comment
✅ All Jest tests passed! This PR is ready to merge. |
✅ All Jest tests passed! This PR is ready to merge. |
✅ All Jest tests passed! This PR is ready to merge. |
@walterbender, I was wondering if we could use the same classNames to render all the dialogue boxes because they have to follow same styles. We can avoid repeated styling. |
That sounds correct. But maybe the Lilypond dialog box might differ because it has additional fields. We should check. |
Yes, I thought about that. Unique elements will require separate styling, but common ones can share the same style. For example, the button in Lilypond - "Save as Lilypond" should have same styling like other buttons. |
Shifting style properties of renderClearConformation to an external CSS file. Also, the clear canvas dialogue box was rendered again if it already existed. This PR has fixed this issue.