Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal to external css #4514

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

Commanderk3
Copy link
Contributor

@Commanderk3 Commanderk3 commented Mar 10, 2025

Shifting style properties of renderClearConformation to an external CSS file. Also, the clear canvas dialogue box was rendered again if it already existed. This PR has fixed this issue.

Copy link

✅ All Jest tests passed! This PR is ready to merge.

1 similar comment
Copy link

✅ All Jest tests passed! This PR is ready to merge.

Copy link

✅ All Jest tests passed! This PR is ready to merge.

Copy link

✅ All Jest tests passed! This PR is ready to merge.

@Commanderk3
Copy link
Contributor Author

Commanderk3 commented Mar 10, 2025

@walterbender, I was wondering if we could use the same classNames to render all the dialogue boxes because they have to follow same styles. We can avoid repeated styling.

@walterbender
Copy link
Member

That sounds correct. But maybe the Lilypond dialog box might differ because it has additional fields. We should check.

@Commanderk3
Copy link
Contributor Author

That sounds correct. But maybe the Lilypond dialog box might differ because it has additional fields. We should check.

Yes, I thought about that. Unique elements will require separate styling, but common ones can share the same style. For example, the button in Lilypond - "Save as Lilypond" should have same styling like other buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants