-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding clear confirmation for both cases in advance mode #4137
adding clear confirmation for both cases in advance mode #4137
Conversation
@walterbender Sir, i have updated the PR. Please review the PR |
@walterbender Sir is this correct or i have to change something |
Can you give a brief overview of the changes you made to help me in the review process? |
@walterbender I think too many confirmation at many places. Won't it make hard for students ? |
The clean button which is present in the canvas for this button it has some specific div and id in index.html. In previous, by using this id the confirmation box was rendered(in turtles.js). But in advance mode when right click on canvas the shortcut for this clear button has no such id . Thats why the confirmation not rendering. But both this button internally called the _allClear() function ( in activity.js) to clean the canvas. So I make the change in such a way that confirmation box rendering functionality in the _allClear() function. Then removed the render of confirmation box from turtle.js because these home page clean button also call the _allClear() function. So in both the cases the handelling of rendering in one function |
renderClearConfirmation in this function confirmation box rendering functionality present.. _allClear() function calls it...and both the button calls allClear() function |
previously the rendering function also there.. I just shifted it from turtles.js to activity.js ..other functionality remains same |
@walterbender Sir, is this okay ? |
@walterbender Sir, is there any changes required ? If any suggestion please let me know. |
Resolve issue #4133
Previously the confirmation don't appear for advance mode shortcut clear option. But now the confirmation box appears for both the cases clean button in canvas as well as shortcut option in advance mode.
Screen.Recording.2024-12-13.121229.mp4