Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding clear confirmation for both cases in advance mode #4137

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

subhas-pramanik-09
Copy link
Contributor

@subhas-pramanik-09 subhas-pramanik-09 commented Dec 13, 2024

Resolve issue #4133

Previously the confirmation don't appear for advance mode shortcut clear option. But now the confirmation box appears for both the cases clean button in canvas as well as shortcut option in advance mode.

Screen.Recording.2024-12-13.121229.mp4

@subhas-pramanik-09 subhas-pramanik-09 changed the title adding conformation for both cases ion advance mode adding clear confirmation for both cases in advance mode Dec 13, 2024
@subhas-pramanik-09
Copy link
Contributor Author

@walterbender Sir, i have updated the PR. Please review the PR

@subhas-pramanik-09
Copy link
Contributor Author

@walterbender Sir is this correct or i have to change something

@walterbender
Copy link
Member

Can you give a brief overview of the changes you made to help me in the review process?

@haroon10725
Copy link
Contributor

haroon10725 commented Dec 13, 2024

@walterbender I think too many confirmation at many places. Won't it make hard for students ?

@subhas-pramanik-09
Copy link
Contributor Author

The clean button which is present in the canvas for this button it has some specific div and id in index.html. In previous, by using this id the confirmation box was rendered(in turtles.js). But in advance mode when right click on canvas the shortcut for this clear button has no such id . Thats why the confirmation not rendering. But both this button internally called the _allClear() function ( in activity.js) to clean the canvas. So I make the change in such a way that confirmation box rendering functionality in the _allClear() function. Then removed the render of confirmation box from turtle.js because these home page clean button also call the _allClear() function. So in both the cases the handelling of rendering in one function

@subhas-pramanik-09
Copy link
Contributor Author

renderClearConfirmation in this function confirmation box rendering functionality present.. _allClear() function calls it...and both the button calls allClear() function

@subhas-pramanik-09
Copy link
Contributor Author

@walterbender I think too many confirmation at many places. Won't it make hard for students ?

previously the rendering function also there.. I just shifted it from turtles.js to activity.js ..other functionality remains same

@subhas-pramanik-09
Copy link
Contributor Author

@walterbender Sir, is this okay ?

@subhas-pramanik-09
Copy link
Contributor Author

@walterbender Sir, is there any changes required ? If any suggestion please let me know.

@walterbender walterbender merged commit b602337 into sugarlabs:master Dec 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants