-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat():optional-dependencies, remove pydantic :( #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhanced dependency management by including all extras. 📦 This ensures all optional features are installed during testing. 🚀
Introduces logging setup for better traceability and debugging. 🛠️
Refactored to conditionally import `ClientSession` and `PIL.Image` using `TYPE_CHECKING`. This ensures that the necessary libraries are imported only when available, and raises informative errors otherwise. This change improves code maintainability and avoids unnecessary imports.
- Changed `logger.warn` to `logger.warning` for better clarity. - Added exception handling for `aiohttp` import to manage missing dependencies. This enhances code readability and robustness. #56
Replaced `loguru` logger import with custom logger from `.logger` module. This change improves consistency and maintainability by centralizing logger configuration. #56
Enhanced environment management by including python-dotenv. This allows reading key-value pairs from a .env file, simplifying environment variable handling.
Added `support_mermaid` function to verify if necessary libraries are installed for mermaid support. Logs an error if mermaid is not supported, improving debugging and user experience.
Introduced `latex_render_case.py` for rendering LaTeX using matplotlib, allowing for customizable background and text colors, dpi, and font size. Additionally, added `inspect_markdownify.py` for converting markdown to Telegram MarkdownV2 style, demonstrating integration with Telegram bot for message sending.
- Renamed `dev` group to `tests` for clarity. - Updated installation commands in README and GitHub Actions. - Ensures dependencies are installed for testing.
- Fix the install command to ensure both mermaid and tests groups are installed - Improves CI reliability by ensuring all necessary dependencies are present
Enhanced the README to include more specific optional dependencies instructions. Improved text formatting for better readability and clarity.
with #57 |
Added a check for Mermaid support in the `MermaidInterpreter` class. If unsupported, logs an error suggesting installing the necessary libraries, preventing task processing without support. This improves user guidance and debugging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pdm-project.org/en/latest/reference/pep621/#optional-dependencies