Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra space added after quote character #21

Closed
nj-vs-vh opened this issue Aug 28, 2024 · 3 comments · Fixed by #22
Closed

Extra space added after quote character #21

nj-vs-vh opened this issue Aug 28, 2024 · 3 comments · Fixed by #22
Labels
enhancement New feature or request

Comments

@nj-vs-vh
Copy link
Contributor

Hi, thanks for the great library!

One small thing I bumped into is that it adds an extra space after block quote symbol (>):

telegramify_markdown.markdownify(">quote")
# result: '> quote\n'

This space is actually preserved by Telegram. For larger quotes it leads to the following problem:

image
@sudoskys
Copy link
Owner

Um, so you expect to align them?

@sudoskys
Copy link
Owner

I'll release a patch to fix this

@sudoskys sudoskys linked a pull request Aug 29, 2024 that will close this issue
Copy link

neutron-nerve bot commented Aug 29, 2024

Report on Issue: Extra Space Added After Quote Character

Issue Summary

Issue Description:
An issue was reported concerning the addition of an extra space after the block quote symbol (>). This issue was identified when using the telegramify_markdown.markdownify function:

telegramify_markdown.markdownify(">quote")
# result: '> quote\n'

This extra space was preserved by Telegram and caused formatting issues, especially with larger quotes.

Issue Details Information
Opened By: @nj-vs-vh
Opened On: 2024-08-28 16:37:02
Closed By: @sudoskys
Closed On: 2024-08-29 11:26:38

Resolution and Outcome

Resolution:
Following the issue report, @sudoskys responded promptly and acknowledged the formatting error. The maintainer ensured that a corrective patch was developed and deployed.

Outcome:
The patch successfully removed the unwanted space after the block quote symbol (>), thereby preserving the desired formatting in Telegram. This resolved the initial issue and improved the overall functionality of the telegramify_markdown library.

Resolved By: @sudoskys

Conclusion

The implementation of a fix for this issue enhances the utility of the telegramify_markdown library by ensuring that block quotes are formatted correctly without extra spaces. This improvement addresses user concerns and maintains the library's effectiveness for creating Telegram messages.

We extend our gratitude to @nj-vs-vh for identifying the issue and reporting it, and to @sudoskys for the prompt resolution.


Thank you all for your contributions.


@sudoskys sudoskys added the enhancement New feature or request label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants