feat: add vehicle attachment compatibility #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'vehicleAttach' / 'vehicleDetach' events are incorrectly documented as of 16th May 2023 (arguments flipped) * arguments relating to an attached vehicle (before or after) refer to the trailer - but may break if towing a vehicle (and does not run a recursive query). * native trailers only appear to accept the hazard variant of the indicators, regardless of what state the truck has been given
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the server has access to vehicle attachment properties, and will check accordingly to reflect the indicator state.
2d65486 notes the incorrect argument signature for the event.