Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix link to protobuf files #598

Merged
merged 1 commit into from
Feb 8, 2024
Merged

docs: fix link to protobuf files #598

merged 1 commit into from
Feb 8, 2024

Conversation

ingomueller-net
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Feb 8, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

westonpace
westonpace requested changes Feb 8, 2024
View reviewed changes
Copy link
Member

@westonpace westonpace left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm marking this "request changes" only because the CLA still needs signed. Once you've done that can you re-request review?

image

@ingomueller-net
Copy link
Contributor Author

I'm marking this "request changes" only because the CLA still needs signed. Once you've done that can you re-request review?

OK, sure. Just had to check with my employer if I am allowed -- and I am :)

@westonpace westonpace merged commit d9b9672 into substrait-io:main Feb 8, 2024
13 checks passed
@westonpace
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonpace westonpace westonpace approved these changes

@jacques-n jacques-n Awaiting requested review from jacques-n jacques-n is a code owner

@cpcloud cpcloud Awaiting requested review from cpcloud cpcloud is a code owner

@EpsilonPrime EpsilonPrime Awaiting requested review from EpsilonPrime EpsilonPrime is a code owner

@vbarua vbarua Awaiting requested review from vbarua vbarua is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ingomueller-net @CLAassistant @westonpace