From 5932eb90edeee7efbdb6ced090ba81dd4b7553a8 Mon Sep 17 00:00:00 2001 From: Andrew Coleman Date: Thu, 6 Feb 2025 00:25:19 +0000 Subject: [PATCH] fix: test coverage miscounting window functions (#784) The window functions were being added to the scalar_functions object in the test script. Signed-off-by: Andrew Coleman --- tests/baseline.json | 4 ++-- tests/coverage/extensions.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/baseline.json b/tests/baseline.json index c30f17ac5..bde8b2093 100644 --- a/tests/baseline.json +++ b/tests/baseline.json @@ -4,8 +4,8 @@ "extension_count": 13, "function_count": 165, "num_aggregate_functions": 29, - "num_scalar_functions": 169, - "num_window_functions": 0, + "num_scalar_functions": 158, + "num_window_functions": 11, "num_function_overloads": 517 }, "coverage": { diff --git a/tests/coverage/extensions.py b/tests/coverage/extensions.py index e66681d27..6c8a44f15 100644 --- a/tests/coverage/extensions.py +++ b/tests/coverage/extensions.py @@ -188,7 +188,7 @@ def read_substrait_extensions(dir_path: str): if "window_functions" in data: Extension.add_functions_to_map( data["window_functions"], - scalar_functions, + window_functions, suffix, extension, uri,