Skip to content

Commit

Permalink
fix: test coverage miscounting window functions (#784)
Browse files Browse the repository at this point in the history
The window functions were being added to the scalar_functions object in
the test script.

Signed-off-by: Andrew Coleman <andrew_coleman@uk.ibm.com>
  • Loading branch information
andrew-coleman authored Feb 6, 2025
1 parent a30b3e2 commit 5932eb9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions tests/baseline.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"extension_count": 13,
"function_count": 165,
"num_aggregate_functions": 29,
"num_scalar_functions": 169,
"num_window_functions": 0,
"num_scalar_functions": 158,
"num_window_functions": 11,
"num_function_overloads": 517
},
"coverage": {
Expand Down
2 changes: 1 addition & 1 deletion tests/coverage/extensions.py
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ def read_substrait_extensions(dir_path: str):
if "window_functions" in data:
Extension.add_functions_to_map(
data["window_functions"],
scalar_functions,
window_functions,
suffix,
extension,
uri,
Expand Down

0 comments on commit 5932eb9

Please sign in to comment.