Skip to content

Commit

Permalink
fix: remove functions definitions w/ invalid return types
Browse files Browse the repository at this point in the history
T? and T|? are not valid return types

T|? is equivalent to setting the nullability to MIRROR
T&? is not currently expressible via nullability

BREAKING CHANGE: least_skip_null and greatest_skip_null functions have been removed
  • Loading branch information
vbarua committed Feb 8, 2024
1 parent d9b9672 commit 1d11122
Showing 1 changed file with 4 additions and 24 deletions.
28 changes: 4 additions & 24 deletions extensions/functions_comparison.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -225,18 +225,8 @@ scalar_functions:
- value: T
variadic:
min: 2
return: T|?
-
name: "least_skip_null"
description: >-
Evaluates each argument and returns the smallest one. The function will return
null only if all arguments evaluate to null.
impls:
- args:
- value: T
variadic:
min: 2
return: T&?
return: T
nullability: MIRROR
-
name: "greatest"
description: >-
Expand All @@ -247,15 +237,5 @@ scalar_functions:
- value: T
variadic:
min: 2
return: T|?
-
name: "greatest_skip_null"
description: >-
Evaluates each argument and returns the largest one. The function will return
null only if all arguments evaluate to null.
impls:
- args:
- value: T
variadic:
min: 2
return: T&?
return: T
nullability: MIRROR

0 comments on commit 1d11122

Please sign in to comment.