fix: TransformLiteralToValue to check decimal bytes length in from_substrait

src/from_substrait.cpp

@@ -114,6 +114,10 @@
 		return {literal.string()};
 	case substrait::Expression_Literal::LiteralTypeCase::kDecimal: {
 		const auto &substrait_decimal = literal.decimal();
+		if (substrait_decimal.value().size() != 16) {
+			throw InvalidInputException("Decimal value must have 16 bytes, but has " +
+			                            std::to_string(substrait_decimal.value().size()));
+		}
 		auto raw_value = reinterpret_cast<const uint64_t *>(substrait_decimal.value().c_str());
 		hugeint_t substrait_value {};
 		substrait_value.lower = raw_value[0];
@@ -164,7 +168,7 @@
 		interval_t interval {};
 		interval.months = 0;
 		interval.days = literal.interval_day_to_second().days();
 		interval.micros = literal.interval_day_to_second().microseconds();
 		return Value::INTERVAL(interval);
 	}
 	case substrait::Expression_Literal::LiteralTypeCase::kVarChar:
@@ -486,8 +490,8 @@
 shared_ptr<Relation> SubstraitToDuckDB::TransformFetchOp(const substrait::Rel &sop,
                                                          const google::protobuf::RepeatedPtrField<std::string> *names) {
 	auto &slimit = sop.fetch();
 	idx_t limit = slimit.count() == -1 ? NumericLimits<idx_t>::Maximum() : slimit.count();
 	idx_t offset = slimit.offset();
 	return make_shared_ptr<LimitRelation>(TransformOp(slimit.input(), names), limit, offset);
 }
 
@@ -519,7 +523,7 @@
 
 	if (sop.aggregate().groupings_size() > 0) {
 		for (auto &sgrp : sop.aggregate().groupings()) {
 			for (auto &sgrpexpr : sgrp.grouping_expressions()) {
 				groups.push_back(TransformExpr(sgrpexpr));
 				expressions.push_back(TransformExpr(sgrpexpr));
 			}
@@ -619,8 +623,8 @@
 		scan = rel->Alias(name);
 	} else if (sget.has_virtual_table()) {
 		// We need to handle a virtual table as a LogicalExpressionGet
 		if (!sget.virtual_table().values().empty()) {
 			auto literal_values = sget.virtual_table().values();
 			vector<vector<Value>> expression_rows;
 			for (auto &row : literal_values) {
 				auto values = row.fields();

test/c/test_substrait_c_api.cpp

@@ -341,20 +341,19 @@ TEST_CASE("Test C VirtualTable input Literal", "[substrait-api]") {
 
   auto json = GetSubstraitJSON(con,"select * from (values (1, 2),(3, 4))");
   REQUIRE(!json.empty());
-  std::cout << json << std::endl;
 
   auto result = FromSubstraitJSON(con,json);
   REQUIRE(CHECK_COLUMN(result, 0, {1, 3}));
   REQUIRE(CHECK_COLUMN(result, 1, {2, 4}));
 }
 
+
 TEST_CASE("Test C VirtualTable input Expression", "[substrait-api]") {
   DuckDB db(nullptr);
   Connection con(db);
 
   auto json = GetSubstraitJSON(con,"select * from (values (1+1,2+2),(3+3,4+4)) as temp(a,b)");
   REQUIRE(!json.empty());
-  std::cout << json << std::endl;
 
   auto result = FromSubstraitJSON(con,json);
   REQUIRE(CHECK_COLUMN(result, 0, {2, 6}));
@@ -701,7 +700,15 @@ TEST_CASE("Test C Project on empty virtual table for SELECT 1", "[substrait-api]
 	DuckDB db(nullptr);
 	Connection con(db);
 
-	auto json_str = R"({"version":{"minorNumber":29, "producer":"substrait-go"}, "relations":[{"root":{"input":{"project":{"common":{"direct":{}}, "input":{"read":{"common":{"direct":{}}, "baseSchema":{"struct":{"nullability":"NULLABILITY_REQUIRED"}}, "virtualTable":{"expressions":[{}]}}}, "expressions":[{"literal":{"decimal":{"value":"AQ==", "precision":1}, "nullable":true}}]}}, "names":["?column?"]}}]})";
+	auto json_str = R"({"version":{"minorNumber":29, "producer":"substrait-go"}, "relations":[{"root":{"input":{"project":{"common":{"direct":{}}, "input":{"read":{"common":{"direct":{}}, "baseSchema":{"struct":{"nullability":"NULLABILITY_REQUIRED"}}, "virtualTable":{"expressions":[{}]}}}, "expressions":[{"literal":{"decimal":{"value":"AQAAAAAAAAAAAAAAAAAAAA==", "precision":1}, "nullable":true}}]}}, "names":["?column?"]}}]})";
 	auto result = FromSubstraitJSON(con,json_str);
 	REQUIRE(CHECK_COLUMN(result, 0, {1}));
 }
+
+TEST_CASE("Test C VirtualTable with bad input Literal", "[substrait-api]") {
+	DuckDB db(nullptr);
+	Connection con(db);
+
+	auto json_plan = R"({"version":{"minorNumber":29, "producer":"substrait-go"}, "relations":[{"root":{"input":{"project":{"common":{"direct":{}}, "input":{"read":{"common":{"direct":{}}, "baseSchema":{"struct":{"nullability":"NULLABILITY_REQUIRED"}}, "virtualTable":{"expressions":[{}]}}}, "expressions":[{"literal":{"decimal":{"value":"AQ==", "precision":1}, "nullable":true}}]}}, "names":["?column?"]}}]})";
+	REQUIRE_THROWS(FromSubstraitJSON(con,json_plan));
+}