feat: add "blender" and "gdb" dev_environments #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfcherng
previously approved these changes
Aug 22, 2024
These two environments will query the additional paths by calling the Blender or gdb executable. More testing is probably needed for Blender on macOS, because it's probably not on the $PATH, and the actual CLI executable is inside the /Applications/Blender.app folder. What's also not great right now is that both these environments have a compiled native extension (_bpy and _gdb, respectively) and both of these applications don't have a corresponding .pyi interface file for these native extensions. Actually, the same problem occurs for Sublime Text (sublime_api module is a native extension). However in the case of Sublime Text, this sublime_api module is completely wrapped in pure python classes/functions. So we don't notice that it doesn't have a .pyi interface file.
rwols
force-pushed
the
blender-and-gdb-dev-environments
branch
from
3491764 to
08261bc
Compare
jfcherng
approved these changes
Aug 23, 2024
jfcherng
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two environments will query the additional paths by calling the Blender or gdb executable. More testing is probably needed for Blender on macOS, because it's probably not on the $PATH, and the actual CLI executable is inside the /Applications/Blender.app folder.
What's also not great right now is that both these environments have a compiled native extension (_bpy and _gdb, respectively) and both of these applications don't have a corresponding .pyi interface file for these native extensions.
Actually, the same problem occurs for Sublime Text (sublime_api module is a native extension). However in the case of Sublime Text, this sublime_api module is completely wrapped in pure python classes/functions. So we don't notice that it doesn't have a .pyi interface file.
close #354
close #353