[Python] Fix function-calls in inherited class definitions #4178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sublimehq#4177 This commit replaces `expression-in-a-group` by the contexts it consists of into `class-definition-base-list-body` to ensure function calls are scoped as expected. Only the `qualified-name` part is replaced by inheritance specific patterns. It also removes a duplicate include of `illegal-names`.
keith-hall
approved these changes
Feb 26, 2025
jfcherng
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4177
This commit replaces
expression-in-a-groupby the contexts it consists of inclass-definition-base-list-bodyto ensure function calls are scoped as expected.Only the
qualified-namepart is replaced by inheritance specific patterns.It also removes a duplicate include of
illegal-names.