- Gradient correction fix

su2code · Sep 25, 2024 · a784a4f · a784a4f
1 parent 317f563
commit a784a4f
Showing 1 changed file with 15 additions and 7 deletions.
diff --git a/SU2_CFD/include/gradients/correctGradientsSymmetry.hpp b/SU2_CFD/include/gradients/correctGradientsSymmetry.hpp
@@ -61,17 +61,25 @@ inline void correctGradient(const size_t varBegin, const size_t varEnd, const in
       }
     }
 
-    /*--- Normal gradient of the normal velocity. ---*/
-    const su2double normalGradNormalVel = GeometryToolbox::DotProduct(nDim, n, gradNormalVel);
+    // /*--- Normal gradient of the normal velocity. ---*/
+    // const su2double normalGradNormalVel = GeometryToolbox::DotProduct(nDim, n, gradNormalVel);
 
-    /*--- Remove the tangential projection (I - n.n^T) of the normal gradients.
-     * And the normal projection (n.n^T) of the tangential gradients.
-     * dV = dV - (I - n.n^T) dV n.n^T - n.n^T dV (I - n.n^T) ---*/
+    // /*--- Remove the tangential projection (I - n.n^T) of the normal gradients.
+    //  * And the normal projection (n.n^T) of the tangential gradients.
+    //  * dV = dV - (I - n.n^T) dV n.n^T - n.n^T dV (I - n.n^T) ---*/
 
+    // for (size_t iDim = 0; iDim < nDim; iDim++) {
+    //   for (size_t jDim = 0; jDim < nDim; jDim++) {
+    //     gradients[idxVel + iDim][jDim] -= normalGrad[iDim] * n[jDim] + n[iDim] * gradNormalVel[jDim];
+    //     gradients[idxVel + iDim][jDim] += 2 * n[iDim] * normalGradNormalVel * n[jDim];
+    //   }
+    // }
+
+    // Do I really need all of the previous code? Can't I just merge the two for loops? Maybe I am missing the tangential direction
     for (size_t iDim = 0; iDim < nDim; iDim++) {
+      const su2double normalGrad = GeometryToolbox::DotProduct(nDim, n, gradients[idxVel + iDim]);
       for (size_t jDim = 0; jDim < nDim; jDim++) {
-        gradients[idxVel + iDim][jDim] -= normalGrad[iDim] * n[jDim] + n[iDim] * gradNormalVel[jDim];
-        gradients[idxVel + iDim][jDim] += 2 * n[iDim] * normalGradNormalVel * n[jDim];
+        gradients[idxVel + iDim][jDim] -= normalGrad * n[jDim];
       }
     }
   }