Fix box sizing bug (#36)

* Fix border-box bug * Build and bump
stuartmemo · Sep 21, 2020 · 2cf4ce3 · 2cf4ce3
1 parent b2699b7
commit 2cf4ce3
Show file tree

Hide file tree

Showing 5 changed files with 48 additions and 10 deletions.
diff --git a/bower.json b/bower.json
@@ -1,7 +1,7 @@
 {
     "name": "qwerty-hancock",
     "main": "dist/qwerty-hancock.js",
-    "version": "0.6.0",
+    "version": "0.6.1",
     "homepage": "http://stuartmemo.com/qwerty-hancock/",
     "authors": [
         {

diff --git a/dist/qwerty-hancock.js b/dist/qwerty-hancock.js
@@ -1,5 +1,5 @@
 /*
- * Qwerty Hancock keyboard library v0.6.0
+ * Qwerty Hancock keyboard library v0.6.1
  * The web keyboard for now people.
  * Copyright 2012-18, Stuart Memo
  *
@@ -15,7 +15,7 @@
      * In node context (browserify), `this` is the node global.
      */
     var globalWindow = typeof global === 'undefined' ? root : root.window;
-    var version = '0.6.0',
+    var version = '0.6.1',
         settings = {},
         mouse_is_down = false,
         keysDown = {},
@@ -87,6 +87,31 @@
         }
 
         settings.startOctave = parseInt(settings.startNote.charAt(1), 10);
+        settings.keyOctave = user_settings.keyOctave || settings.startOctave;
+
+        // Add getters and setters
+        this.setKeyOctave = function(octave){
+            settings.keyOctave = octave;
+            return settings.keyOctave;
+        }
+        this.getKeyOctave = function(){
+            return settings.keyOctave;
+        }
+        this.keyOctaveUp = function(){
+            settings.keyOctave++;
+            return settings.keyOctave;
+        }
+        this.keyOctaveDown = function(){
+            settings.keyOctave--;
+            return settings.keyOctave;
+        }
+        this.getKeyMap = function(){
+            return key_map;
+        }
+        this.setKeyMap = function(newKeyMap){
+            key_map = newKeyMap;
+            return key_map;
+        }
 
         createKeyboard();
         addListeners.call(this, container);
@@ -236,6 +261,7 @@
             el.style.margin = 0;
             el.style.width = settings.width + 'px';
             el.style['-webkit-user-select'] = 'none';
+            el.style.boxSizing = 'content-box';
         };
 
         styleElement(keyboard.container);
@@ -388,8 +414,8 @@
 
     var getKeyPressed = function (keyCode) {
         return key_map[keyCode]
-                .replace('l', parseInt(settings.startOctave, 10) + settings.keyPressOffset)
-                .replace('u', (parseInt(settings.startOctave, 10) + settings.keyPressOffset + 1)
+                .replace('l', parseInt(settings.keyOctave, 10) + settings.keyPressOffset)
+                .replace('u', (parseInt(settings.keyOctave, 10) + settings.keyPressOffset + 1)
                 .toString());
     };
 
@@ -530,6 +556,17 @@
             // Placeholder function.
         };
 
+        this.setKeyOctave = function(octave){
+            // Placeholder function.
+        };
+
+        this.getKeyOctave = function(){};
+        this.keyOctaveUp = function(){};
+        this.keyOctaveDown = function(){};
+
+        this.getKeyMap = function(){};
+        this.setKeyMap = function(newKeyMap){};
+
         init.call(this, settings);
     };
 

diff --git a/dist/qwerty-hancock.min.js b/dist/qwerty-hancock.min.js
diff --git a/package.json b/package.json
@@ -3,7 +3,7 @@
   "name": "qwerty-hancock",
   "title": "Qwerty Hancock",
   "description": "An interactive HTML plugin-free keyboard for your web audio project.",
-  "version": "0.6.0",
+  "version": "0.6.1",
   "main": "dist/qwerty-hancock.js",
   "repository": {
     "type": "git",

diff --git a/src/qwerty-hancock.js b/src/qwerty-hancock.js
@@ -1,5 +1,5 @@
 /*
- * Qwerty Hancock keyboard library v0.6.0
+ * Qwerty Hancock keyboard library v0.6.1
  * The web keyboard for now people.
  * Copyright 2012-18, Stuart Memo
  *
@@ -15,7 +15,7 @@
      * In node context (browserify), `this` is the node global.
      */
     var globalWindow = typeof global === 'undefined' ? root : root.window;
-    var version = '0.6.0',
+    var version = '0.6.1',
         settings = {},
         mouse_is_down = false,
         keysDown = {},
@@ -261,6 +261,7 @@
             el.style.margin = 0;
             el.style.width = settings.width + 'px';
             el.style['-webkit-user-select'] = 'none';
+            el.style.boxSizing = 'content-box';
         };
 
         styleElement(keyboard.container);