Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'TAG' as a supported fieldtype for requirement nodes #1959

Merged

Conversation

mplum
Copy link
Contributor

@mplum mplum commented Oct 25, 2024

From the manual, tag is supported for Requirement nodes:
https://strictdoc.readthedocs.io/en/stable/strictdoc_01_user_guide.html#id6

Problem:
grammar defines "TAG" field for a Requirement element:

  • TITLE: TAGS
    TYPE: Tag
    REQUIRED: False

Using the web, I get a NotImplementedError exception when trying to create a new requirement:
NotImplementedError: GrammarElementFieldTag(title = "TAGS", human_title = NoneType(...),

Resolved by adding the TAG field to RequirementFieldType

@stanislaw
Copy link
Collaborator

Thanks for contributing! You will have to run invoke check locally to get through the linting errors and tests.

@stanislaw stanislaw force-pushed the bugfix/requirement_tag_field branch from 1736e8c to 08467da Compare October 26, 2024 10:06
@stanislaw
Copy link
Collaborator

Just a heads up: I have fixed it myself and pushed to your branch.

@stanislaw
Copy link
Collaborator

I am preparing a small bugfix release and wanted to have your fixes in it already.

@stanislaw stanislaw merged commit d01cd9a into strictdoc-project:main Oct 26, 2024
22 checks passed
@stanislaw stanislaw added this to the 2024-Q4 milestone Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants