Limit parallel execution of a stage's layer #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sduchesneau
requested changes
Jan 30, 2025
service/tier1.go
Outdated
| requestDetails.MaxParallelJobs = count | ||
| } | ||
| } | ||
| if parallelExecutors := auth.Get("X-Sf-Substreams-Stage-Layer-Parallel-Executor-Max-Count"); parallelExecutors != "" { |
There was a problem hiding this comment.
need to:
- implement the same parsing in tier2.go
- ensure we pass that header down to tier2 request
maoueh
force-pushed
the
feature/limit-execution-parallelism
branch
from
e9bbdb1 to
2fcfb47
Compare
sduchesneau
requested changes
Jan 31, 2025
reqctx/context.go
Outdated
|
|
||
| const safeguardMaxStageLayerParallelExecutorCount = 16 | ||
|
|
||
| // MaxParallelJobs returns the maximum number of parallel executors (e.g. go routines) that can |
There was a problem hiding this comment.
typo, should be MaxStageLayerParallelExecutor
pipeline/process_block.go
Outdated
| logging.Logger(ctx, p.stores.logger).Debug("executing stage's layers", zap.Int("layer_count", len(p.StagedModuleExecutors)), zap.Uint64("max_parallel_executor", maxParallelExecutor)) | ||
|
|
||
| for _, layer := range p.StagedModuleExecutors { | ||
| if isDevelopmentMode || maxParallelExecutor <= 1 || len(layer) <= 1 { |
There was a problem hiding this comment.
why do we care here about isDevelopmentMode ?
The MaxStageLayerParallelExecutor should check that we are in development mode and return 1. This logic doesn't belong here.
| } | ||
|
|
||
| // If unset, provide default value which is 2 for now | ||
| if details.MaxStageLayerParallelExecutor == 0 { |
There was a problem hiding this comment.
as mentionned earlier, add the check for IsInDevelopmentMode here and return 1 ...
Previously, the engine was executing modules in a stage's layer all in parallel. So if you had 20 independent mapper modules, they were all run in parallel. This was hindering performance on high load where a lot of CPU cycles can be consumed will the machine has limited physical cores available. We now change that behavior, development mode will not execute any modules in parallel, never. For production mode, we now limit to 2 parallel execution. A future update will make that value dynamic based on the subscription of the request.
maoueh
force-pushed
the
feature/limit-execution-parallelism
branch
from
2fcfb47 to
207dae8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the engine was executing modules in a stage's layer all in parallel. So if you had 20 independent mapper modules, they were all run in parallel.
This was hindering performance on high load where a lot of CPU cycles can be consumed will the machine has limited physical cores available.
We now change that behavior, development mode will not execute any modules in parallel, never. For production mode, we now limit to 2 parallel execution. A future update will make that value dynamic based on the subscription of the request.