Output settings form to react #5299
Conversation
BundleMonFiles updated (1)
Unchanged files (3)
Total files change +11.07KB +0.09% Final result: ✅ View report in BundleMon website ➡️ |
| options?: Omit<IObsListOption<unknown>, 'description'>[]; | ||
| } | ||
|
|
||
| const ObsInputListCustomInput = forwardRef<{}, IObsInputListCustomInputProps>((p, ref) => { |
There was a problem hiding this comment.
hmm im not sure this component should be named so generically when it has a lot of code dedicated to handling custom resolutions specifically
| /** | ||
| * @remark Note: The following is a copy of the shared component `TextInput` but with the reference forwarded. | ||
| * This is to allow form validation to work correctly. | ||
| */ |
There was a problem hiding this comment.
i wonder if it would make more sense to just forward the refs on these shared components?
| label: $t(tab), | ||
| key: tab, | ||
| })); | ||
| } |
There was a problem hiding this comment.
is there a reason to restructure the props and format them here instead of just doing this formatting before passing in the tabs under the data prop?
|
|
||
| const type = settingsFormData[0].parameters[0].currentValue === 'Simple' ? 'collapsible' : 'tabs'; | ||
|
|
||
| return <ObsGenericSettingsForm type={type as IObsFormType} />; |
There was a problem hiding this comment.
looking at how light this component is i wonder if it would make more sense to do more of the output settings specific layout handling here with the tabs and collapsible instead of in ObsGenericSettingsForm, it feels a bit weird to me to put a lot of things specific to one settings page in a generic component
No description provided.