Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Can we add Starlette on on Integrations section? #1284

Closed
Kludex opened this issue Sep 30, 2021 · 3 comments · Fixed by #1287
Closed

[DOCS] Can we add Starlette on on Integrations section? #1284

Kludex opened this issue Sep 30, 2021 · 3 comments · Fixed by #1287

Comments

@Kludex
Copy link
Member

Kludex commented Sep 30, 2021

Hi! 👋

I'm part of encode, and we're going to remove the native GraphQL from Starlette, check here.

Currently, it's already deprecated, and we recommend a set of packages that can be used to work with GraphQL, which strawberry is one of them. And... I'm planning on refactoring the GraphQL docs page on Starlette to point to some different tutorial integrations.

That being said, I was wondering if we could add an analogous page of the current FastAPI integration to Starlette. I know it's trivial, but it will be cool anyway. :)

Furthermore, I can create the PR, I just wanted to ask first.

@patrick91
Copy link
Member

@Kludex why not! we have the ASGI section that is basically that (our ASGI integration is based on Starlette :D)

Do you think we should rename that or just create a new page and link to the asgi section for further information?

btw happy to review and merge the PR :)

@Kludex
Copy link
Member Author

Kludex commented Sep 30, 2021

Hmmm... I'm not sure. What I had in mind is to see the integration explicitly.

Maybe importing Starlette here and changing some wording?

image

Like "Once that's done, you can use Strawberry with ASGI, see the example with Starlette:"

Or just a page... 😅

@patrick91
Copy link
Member

let’s go with a page, we can figure later what to do with the ASGI page 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants