feat: support other coin decimals, e.g. Ethermint #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reecepbcups
changed the title
Reecepbcups
changed the title
|
@ItayLevyOfficial this is running locally for me with dymension and 18 coin decimals. Here is the setup lmk if you run into issues A future PR can add support for specific Ethermint functions (e.g. 0x hex address things) |
Reecepbcups
changed the title
boojamya
reviewed
Nov 9, 2023
|
@Mergifyio backport v7 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 19, 2023
* move to math.NewInt * mod tidy * ethermint support + chain example * remove c.CoinDecimals from isFullyConfigured check * revert accidental hyperspace finalStakeBal change * use heighliner image * remove unused docker state export --------- Co-authored-by: Dan Kanefsky <daniel.kanefsky@gmail.com> (cherry picked from commit a033ba4) # Conflicts: # chain/cosmos/cosmos_chain.go # examples/cosmos/chain_upgrade_ibc_test.go # examples/cosmwasm/rust-optimizer/rust_optimizer_test.go # examples/cosmwasm/workspace-optimizer/workspace_optimizer_test.go # examples/hyperspace/hyperspace_test.go # examples/penumbra/penumbra_chain_test.go # go.sum # go.work.sum
Reecepbcups
added a commit
that referenced
this pull request
Dec 4, 2023
* feat: support other coin decimals, e.g. Ethermint (#866) * move to math.NewInt * mod tidy * ethermint support + chain example * remove c.CoinDecimals from isFullyConfigured check * revert accidental hyperspace finalStakeBal change * use heighliner image * remove unused docker state export --------- Co-authored-by: Dan Kanefsky <daniel.kanefsky@gmail.com> (cherry picked from commit a033ba4) # Conflicts: # chain/cosmos/cosmos_chain.go # examples/cosmos/chain_upgrade_ibc_test.go # examples/cosmwasm/rust-optimizer/rust_optimizer_test.go # examples/cosmwasm/workspace-optimizer/workspace_optimizer_test.go # examples/hyperspace/hyperspace_test.go # examples/penumbra/penumbra_chain_test.go # go.sum # go.work.sum * mod tidy + sdkmath * remove unused features from v7 (CW compile) --------- Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com> Co-authored-by: Reece Williams <reecepbcups@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #854, #835 (evm usage)
summary
CoinDecimals *int64to ibc.ChainConfig (default is 6 or 18 depending on cointype)