Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSF: Add base factories #30416

Draft
wants to merge 8 commits into
base: kasper/csf-factories
Choose a base branch
from

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Jan 29, 2025

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.9 MB 77.9 MB 5.66 kB 2.05 0%
initSize 132 MB 132 MB 78.2 kB -0.44 0.1%
diffSize 53.8 MB 53.9 MB 72.5 kB -0.5 0.1%
buildSize 7.19 MB 7.22 MB 24 kB 24.86 0.3%
buildSbAddonsSize 1.85 MB 1.85 MB -2.3 kB -19.42 -0.1%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.87 MB 1.87 MB 0 B 1.11 0%
buildSbPreviewSize 0 B 0 B 0 B - -
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.91 MB 3.91 MB -2.3 kB -1.83 -0.1%
buildPreviewSize 3.28 MB 3.3 MB 26.3 kB 93.9 0.8%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 18.1s 26.4s 8.3s 1.22 31.4%
generateTime 26s 20.3s -5s -732ms -0.38 -28.2%
initTime 14.3s 13s -1s -310ms -0.84 -10%
buildTime 9.8s 8.9s -834ms -0.83 -9.3%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 4.8s 5s 131ms -0.18 2.6%
devManagerResponsive 3.5s 3.8s 299ms 0.42 7.9%
devManagerHeaderVisible 568ms 553ms -15ms -1.23 -2.7%
devManagerIndexVisible 605ms 579ms -26ms -1.17 -4.5%
devStoryVisibleUncached 1.9s 2s 55ms 0.39 2.7%
devStoryVisible 606ms 587ms -19ms -1.17 -3.2%
devAutodocsVisible 514ms 571ms 57ms 0.72 10%
devMDXVisible 533ms 603ms 70ms 1.04 11.6%
buildManagerHeaderVisible 536ms 534ms -2ms -0.6 -0.4%
buildManagerIndexVisible 542ms 537ms -5ms -0.6 -0.9%
buildStoryVisible 528ms 525ms -3ms -0.6 -0.6%
buildAutodocsVisible 433ms 439ms 6ms -0.55 1.4%
buildMDXVisible 397ms 412ms 15ms -1.07 3.6%

@kasperpeulen kasperpeulen changed the base branch from next to kasper/csf-factories January 29, 2025 15:56
Copy link
Contributor

Fails
🚫

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","build","dependencies"]

🚫

PR is not labeled with one of: ["ci:normal","ci:merged","ci:daily","ci:docs"]

🚫 PR title must be in the format of "Area: Summary", With both Area and Summary starting with a capital letter Good examples: - "Docs: Describe Canvas Doc Block" - "Svelte: Support Svelte v4" Bad examples: - "add new api docs" - "fix: Svelte 4 support" - "Vue: improve docs"

Generated by 🚫 dangerJS against 8ceedc1

Copy link

nx-cloud bot commented Jan 29, 2025

View your CI Pipeline Execution ↗ for commit d5b592a.

Command Status Duration Result
nx run-many -t build -c production --parallel=3 ❌ Failed 16s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-30 15:01:32 UTC

@yannbf yannbf changed the title Kasper/base factories CSF: Add base factories Jan 30, 2025
@storybook-pr-benchmarking
Copy link

Package Benchmarks

Commit: b93d96a, ran on 30 January 2025 at 12:05:43 UTC

The following packages have significant changes to their size or dependencies:

@storybook/addon-storysource

Before After Difference
Dependency count 7 7 0
Self size 1.89 MB 1.89 MB 0 B
Dependency size 10.73 MB 10.79 MB 🚨 +63 KB 🚨
Bundle Size Analyzer Link Link

@storybook/core

Before After Difference
Dependency count 54 54 0
Self size 19.06 MB 19.11 MB 🚨 +48 KB 🚨
Dependency size 14.43 MB 14.43 MB 🚨 +734 B 🚨
Bundle Size Analyzer Link Link

storybook

Before After Difference
Dependency count 55 55 0
Self size 22 KB 23 KB 🚨 +380 B 🚨
Dependency size 33.50 MB 33.54 MB 🚨 +49 KB 🚨
Bundle Size Analyzer Link Link

sb

Before After Difference
Dependency count 56 56 0
Self size 1 KB 1 KB 0 B
Dependency size 33.52 MB 33.57 MB 🚨 +49 KB 🚨
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 390 390 0
Self size 530 KB 530 KB 0 B
Dependency size 75.30 MB 75.41 MB 🚨 +112 KB 🚨
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 277 277 0
Self size 612 KB 612 KB 0 B
Dependency size 65.37 MB 65.48 MB 🚨 +111 KB 🚨
Bundle Size Analyzer Link Link

create-storybook

Before After Difference
Dependency count 113 113 0
Self size 1.11 MB 1.11 MB 0 B
Dependency size 42.63 MB 42.68 MB 🚨 +49 KB 🚨
Bundle Size Analyzer Link Link

@storybook/source-loader

Before After Difference
Dependency count 5 5 0
Self size 41 KB 41 KB 0 B
Dependency size 10.67 MB 10.73 MB 🚨 +63 KB 🚨
Bundle Size Analyzer Link Link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants