Update storybook-interactions-play-function.md #30375
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace onSubmit -> submit, and mention it's an output to make things more angulary https://angular.dev/style-guide#dont-prefix-output-properties
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -8,8 +8,8 @@ import { Form } from './Form.component'; | |||
| const meta: Meta<Form> = { | |||
| component: MyComponent, | |||
There was a problem hiding this comment.
logic: MyComponent is used here but Form is imported. This appears to be a typo.
Comment on lines
+11
to
+12
| // 👇 Use `fn` to spy on the submit output | ||
| submit: fn(), |
There was a problem hiding this comment.
style: This change to 'submit' is only made in the Angular example but not in other framework examples. Consider whether this should be consistent across all frameworks or if it should be explicitly noted as Angular-specific.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace onSubmit -> submit, and mention it's an output to make things more angulary
https://angular.dev/style-guide#dont-prefix-output-properties
This is purely docs change and shouldn't affect anything outside
Greptile Summary
Updates documentation to align with Angular's style guide by replacing 'onSubmit' with 'submit' for output properties, but introduces inconsistencies in property naming across examples.
docs/_snippets/storybook-interactions-play-function.mdwhere 'onSubmit' and 'submit' are used interchangeably💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!